Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 6003: Portable swscanf.... (Closed)

Created:
12 years, 2 months ago by please use my chromium address
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Portable swscanf. This is one of changes required for http://codereview.chromium.org/4247 (porting in chrome/browser/ ). For Windows there should be swscanf_s, which of course doesn't exist on Linux. #ifdefs would be ugly, this seems to be better way. BUG=2333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M base/string_util.h View 2 chunks +11 lines, -0 lines 0 comments Download
M base/string_util_posix.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/string_util_win.h View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
please use my chromium address
12 years, 2 months ago (2008-09-30 08:51:15 UTC) #1
Dean McNamee
This had been attempted before, and isn't really possible because of the potential differences of ...
12 years, 2 months ago (2008-09-30 13:22:40 UTC) #2
please use my chromium address
12 years, 2 months ago (2008-09-30 16:10:16 UTC) #3
On 2008/09/30 13:22:40, Dean McNamee wrote:
> This had been attempted before, and isn't really possible because of the
> potential differences of the format strings across platforms. :\
> 
> Looks Bummer To Me.
> 
> http://codereview.chromium.org/6003/diff/1/4
> File base/string_util_win.h (right):
> 
> http://codereview.chromium.org/6003/diff/1/4#newcode27
> Line 27: return ::vswscanf_s(ws, format, arguments);
> The problem is that the arguments could be different between the platforms,
> depending on what format string you use.  swscanf_s will take more parameters
> for string buffer sizes if you're using a format with strings.

Should I close this? Maybe I can make changes in
http://codereview.chromium.org/4247 not requiring swscanf.

Powered by Google App Engine
This is Rietveld 408576698