Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 600233002: Update mojo for changes to createMediaPlayer() (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
Reviewers:
jamesr, ddorwin
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update mojo for changes to createMediaPlayer() createMediaPlayer() will soon get called with the additional parameter |initial_cdm|. Adding a method to include it. BUG=358271 TEST=mojo compiles with upcoming blink changes Committed: https://crrev.com/f1c60439c4f0eecf559eec4324f9ddeaee039f99 Cr-Commit-Position: refs/heads/master@{#296597}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M mojo/services/html_viewer/html_document_view.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
jrummell
PTAL. I missed some mojo changes in https://codereview.chromium.org/594713002/ (needed by https://codereview.chromium.org/423633002/).
6 years, 2 months ago (2014-09-24 23:21:43 UTC) #2
jamesr
lgtm
6 years, 2 months ago (2014-09-24 23:24:17 UTC) #3
jrummell
Thanks for the quick review.
6 years, 2 months ago (2014-09-24 23:26:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600233002/1
6 years, 2 months ago (2014-09-24 23:31:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18792)
6 years, 2 months ago (2014-09-24 23:46:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600233002/1
6 years, 2 months ago (2014-09-25 00:04:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b0f1ff88f71a855df8d16f95ec2c9923c9a5397
6 years, 2 months ago (2014-09-25 00:50:53 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1c60439c4f0eecf559eec4324f9ddeaee039f99 Cr-Commit-Position: refs/heads/master@{#296597}
6 years, 2 months ago (2014-09-25 00:51:30 UTC) #12
ddorwin
6 years, 2 months ago (2014-09-25 00:56:52 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/600233002/diff/1/mojo/services/html_viewer/ht...
File mojo/services/html_viewer/html_document_view.cc (right):

https://codereview.chromium.org/600233002/diff/1/mojo/services/html_viewer/ht...
mojo/services/html_viewer/html_document_view.cc:188: return
createMediaPlayer(frame, url, client);
Really, the factory should be updated to accept initial_cdm. This should be
pretty straightforward since this just ends up creating a WMPI.

You can do this when you remove the old signature above.

Powered by Google App Engine
This is Rietveld 408576698