Issue 60021: An empty MIME type doesn't match any plugin, no matter what they may claim....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60021: An empty MIME type doesn't match any plugin, no matter what they may claim.... (Closed)

Created:
11 years, 8 months ago by Pam (message me for reviews)

Modified:
9 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

An empty MIME type doesn't match any plugin, no matter what they may claim. BUG=9549 TEST=install Silverlight, 'run_webkit_tests.sh --force LayoutTests/webarchive/loading', see no crashes (timeouts are OK) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13051

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/glue/webframeloaderclient_impl.cc	View		2 chunks	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/60021/diff/1/2 File webkit/glue/webframeloaderclient_impl.cc (right): http://codereview.chromium.org/60021/diff/1/2#newcode1543 Line 1543: if (!mime_type.isEmpty() && plugin_data && plugin_data->supportsMimeType(mime_type)) I believe ...

11 years, 8 months ago (2009-04-02 20:31:33 UTC) #2

Pam (message me for reviews)

11 years, 8 months ago (2009-04-02 20:34:07 UTC) #4

http://codereview.chromium.org/60021/diff/1/2
File webkit/glue/webframeloaderclient_impl.cc (right):

http://codereview.chromium.org/60021/diff/1/2#newcode1543
Line 1543: if (!mime_type.isEmpty() && plugin_data &&
plugin_data->supportsMimeType(mime_type))
On 2009/04/02 20:31:34, John Abd-El-Malek wrote:
> I believe this one isn't needed because of line 1527

Right. Removed.

Expand Messages | Collapse Messages