Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 600203002: Revert of [Suggestions] Move ImageManager to the component (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Mathieu, huangs, blundell
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Suggestions] Move ImageManager to the component (patchset #6 id:220001 of https://codereview.chromium.org/543753002/) Reason for revert: One of the new unit tests failed with uninit memory access: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/43137/ Original issue's description: > [Suggestions] Move ImageManager to the component > > Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions. > > BUG=387751 > TBR=blundell > TEST=ImageManagerTest,ImageFetcherBrowserTest > > Committed: https://crrev.com/5a25f30080dd57d200679546c970d70f2247def9 > Cr-Commit-Position: refs/heads/master@{#296503} TBR=huangs@chromium.org,blundell@chromium.org,mathp@chromium.org NOTREECHECKS=true NOTRY=true BUG=387751 Committed: https://crrev.com/da4b14f0affb40a6c4d3452a148f2383a48eefce Cr-Commit-Position: refs/heads/master@{#296553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+810 lines, -945 lines) Patch
D chrome/browser/search/suggestions/image_fetcher_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/search/suggestions/image_fetcher_impl.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
A chrome/browser/search/suggestions/image_manager_impl.h View 1 chunk +170 lines, -0 lines 0 comments Download
A chrome/browser/search/suggestions/image_manager_impl.cc View 1 chunk +278 lines, -0 lines 0 comments Download
A chrome/browser/search/suggestions/image_manager_impl_browsertest.cc View 1 chunk +277 lines, -0 lines 0 comments Download
A chrome/browser/search/suggestions/image_manager_impl_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service_factory.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/suggestions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M components/suggestions/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/suggestions/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/suggestions/image_fetcher.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/suggestions/image_fetcher_delegate.h View 1 chunk +0 lines, -29 lines 0 comments Download
M components/suggestions/image_manager.h View 1 chunk +11 lines, -126 lines 0 comments Download
D components/suggestions/image_manager.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D components/suggestions/image_manager_unittest.cc View 1 chunk +0 lines, -193 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of [Suggestions] Move ImageManager to the component
6 years, 3 months ago (2014-09-24 23:00:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600203002/1
6 years, 3 months ago (2014-09-24 23:02:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d2089ea93b116a8daa50a11563691e3c26e5b991
6 years, 3 months ago (2014-09-24 23:03:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:04:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da4b14f0affb40a6c4d3452a148f2383a48eefce
Cr-Commit-Position: refs/heads/master@{#296553}

Powered by Google App Engine
This is Rietveld 408576698