Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 600163003: Use base::StringPairs where appropriate from /content (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs where appropriate from /content Because base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/542c416be33f1cc748530f20db2025f43f490b30 Cr-Commit-Position: refs/heads/master@{#296649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/common/resource_devtools_info.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years, 3 months ago (2014-09-25 04:01:38 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-25 04:07:09 UTC) #3
anujsharma
On 2014/09/25 04:07:09, Avi wrote: > lgtm Thanks Avi for lgtm
6 years, 3 months ago (2014-09-25 04:07:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/600163003/1
6 years, 3 months ago (2014-09-25 04:08:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f97693bcf7cb1827da974756971db3c91666a1d6
6 years, 3 months ago (2014-09-25 05:02:03 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 05:03:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/542c416be33f1cc748530f20db2025f43f490b30
Cr-Commit-Position: refs/heads/master@{#296649}

Powered by Google App Engine
This is Rietveld 408576698