chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 600153004: Refactor SafeBrowsing and SSL interstitials to have a type variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 600153004: Refactor SafeBrowsing and SSL interstitials to have a type variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index 4c530f8c117ba1c91a891d11d374fdffaa57a8e7..6779741fd373a59fb80610413b415228ef78c256 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -689,7 +689,7 @@ std::string SafeBrowsingBlockingPage::GetHTMLContents() {

// Fill in the shared values.

base::DictionaryValue load_time_data;

webui::SetFontAndTextDirection(&load_time_data);

- load_time_data.SetBoolean("ssl", false);

+ load_time_data.SetString("type", "SAFEBROWSING");

load_time_data.SetString(

"tabTitle", l10n_util::GetStringUTF16(IDS_SAFEBROWSING_V3_TITLE));

load_time_data.SetString(

« no previous file with comments | « chrome/browser/resources/security_warnings/ssl.js ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »