chrome/browser/resources/security_warnings/safe_browsing.js - Issue 600153004: Refactor SafeBrowsing and SSL interstitials to have a type variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/security_warnings/safe_browsing.js

Issue 600153004: Refactor SafeBrowsing and SSL interstitials to have a type variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/security_warnings/interstitial_v2.js ('k') | chrome/browser/resources/security_warnings/ssl.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/security_warnings/safe_browsing.js

diff --git a/chrome/browser/resources/security_warnings/safe_browsing.js b/chrome/browser/resources/security_warnings/safe_browsing.js

index 6c7ea2aeedbd11cf9a87bef7e98f8ff655cfdf75..bb154f95bbc5869d9670957c8621ffe8c703df90 100644

--- a/chrome/browser/resources/security_warnings/safe_browsing.js

+++ b/chrome/browser/resources/security_warnings/safe_browsing.js

@@ -18,7 +18,8 @@ var SB_DISPLAY_CHECK_BOX = 'displaycheckbox';

// This sets up the Extended Safe Browsing Reporting opt-in.

function setupCheckbox() {

- if (loadTimeData.getBoolean('ssl') || loadTimeData.getBoolean('phishing') ||

+ if (loadTimeData.getString('type') != 'SAFEBROWSING' ||

+ loadTimeData.getBoolean('phishing') ||

!loadTimeData.getBoolean(SB_DISPLAY_CHECK_BOX)) {

return;

}

« no previous file with comments | « chrome/browser/resources/security_warnings/interstitial_v2.js ('k') | chrome/browser/resources/security_warnings/ssl.js » ('j') | no next file with comments »