Refactor SafeBrowsing and SSL interstitials to have a type variable

chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 4c530f8c117ba1c91a891d11d374fdffaa57a8e7..4dddb55187595f67a822c117c0540e7128ab5423 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -689,7 +689,7 @@ std::string SafeBrowsingBlockingPage::GetHTMLContents() {
   // Fill in the shared values.
   base::DictionaryValue load_time_data;
   webui::SetFontAndTextDirection(&load_time_data);
-  load_time_data.SetBoolean("ssl", false);
+  load_time_data.SetString("type", "safeBrowsing");

[mattm, 2014/09/25 21:27:26]

Lowercase s seems a little weird. Is there some style this is following, or
could it be SafeBrowsing or safe_browsing instead?

[meacer, 2014/09/25 21:46:09]

I wanted to follow the convention with other variable names below this line
(tabTitle, openDetails etc), even though this is actually the value and not the
variable name. I don't mind changing it though.

[mattm, 2014/09/25 21:49:57]

In that case, it seems more like it should follow the style of constant or maybe
enum naming rather than a variable.

[meacer, 2014/09/25 21:58:33]

Done, I assumed Safebrowsing is a single word.

   load_time_data.SetString(
       "tabTitle", l10n_util::GetStringUTF16(IDS_SAFEBROWSING_V3_TITLE));
   load_time_data.SetString(