Refactor SafeBrowsing and SSL interstitials to have a type variable

chrome/browser/resources/security_warnings/interstitial_v2.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the shared code for the new (Chrome 37) security interstitials. It is
 // used for both SSL interstitials and Safe Browsing interstitials.
 
 var expandedDetails = false;
 var keyPressState = 0;
 
 /*
  * A convenience method for sending commands to the parent page.
  * @param {string} cmd  The command to send.
  */
 function sendCommand(cmd) {
   window.domAutomationController.setAutomationId(1);
   window.domAutomationController.send(cmd);
 }
 
 /*
  * This allows errors to be skippped by typing "danger" into the page.
  * @param {string} e The key that was just pressed.
  */
 function handleKeypress(e) {
   var BYPASS_SEQUENCE = 'danger';
   if (BYPASS_SEQUENCE.charCodeAt(keyPressState) == e.keyCode) {
     keyPressState++;
     if (keyPressState == BYPASS_SEQUENCE.length) {
-      sendCommand(CMD_PROCEED);
+      sendCommand(SSL_CMD_PROCEED);
       keyPressState = 0;
     }
   } else {
     keyPressState = 0;
   }
 }
 
 function setupEvents() {
   var overridable = loadTimeData.getBoolean('overridable');
-  var ssl = loadTimeData.getBoolean('ssl');
+  var ssl = loadTimeData.getString('type') === 'ssl';
 
   if (ssl) {
     $('body').classList.add('ssl');
     $('error-code').textContent = loadTimeData.getString('errorCode');
     $('error-code').classList.remove('hidden');
   } else {
     $('body').classList.add('safe-browsing');
   }
 
   $('primary-button').addEventListener('click', function() {
     if (!ssl)
       sendCommand(SB_CMD_TAKE_ME_BACK);
     else if (overridable)
-      sendCommand(CMD_DONT_PROCEED);
+      sendCommand(SSL_CMD_DONT_PROCEED);
     else
-      sendCommand(CMD_RELOAD);
+      sendCommand(SSL_CMD_RELOAD);
   });
 
   if (overridable) {
     $('proceed-link').addEventListener('click', function(event) {
-      sendCommand(ssl ? CMD_PROCEED : SB_CMD_PROCEED);
+      sendCommand(ssl ? SSL_CMD_PROCEED : SB_CMD_PROCEED);
     });
   } else if (!ssl) {
     $('final-paragraph').classList.add('hidden');
   }
 
   if (ssl && overridable) {
     $('proceed-link').classList.add('small-link');
   } else if ($('help-link')) {
     // Overridable SSL page doesn't have this link.
     $('help-link').addEventListener('click', function(event) {
       if (ssl)
-        sendCommand(CMD_HELP);
+        sendCommand(SSL_CMD_HELP);
       else if (loadTimeData.getBoolean('phishing'))
         sendCommand(SB_CMD_LEARN_MORE_2);
       else
         sendCommand(SB_CMD_SHOW_DIAGNOSTIC);
     });
   }
 
   if (ssl && $('clock-link')) {
     $('clock-link').addEventListener('click', function(event) {
-      sendCommand(CMD_CLOCK);
+      sendCommand(SSL_CMD_CLOCK);
     });
   }
 
   $('details-button').addEventListener('click', function(event) {
     var hiddenDetails = $('details').classList.toggle('hidden');
     $('details-button').innerText = hiddenDetails ?
         loadTimeData.getString('openDetails') :
         loadTimeData.getString('closeDetails');
     if (!expandedDetails) {
       // Record a histogram entry only the first time that details is opened.
-      sendCommand(ssl ? CMD_MORE : SB_CMD_EXPANDED_SEE_MORE);
+      sendCommand(ssl ? SSL_CMD_MORE : SB_CMD_EXPANDED_SEE_MORE);
       expandedDetails = true;
     }
   });
 
   preventDefaultOnPoundLinkClicks();
   setupCheckbox();
   document.addEventListener('keypress', handleKeypress);
 }
 
 document.addEventListener('DOMContentLoaded', setupEvents);