public/platform/WebMediaPlayerClient.h - Issue 600143005: Rename onneedkey event to onencrypted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebMediaPlayerClient.h

Issue 600143005: Rename onneedkey event to onencrypted. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rename keyNeeded() to encrypted(). Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebMediaPlayerClient.h

diff --git a/public/platform/WebMediaPlayerClient.h b/public/platform/WebMediaPlayerClient.h

index 48043d37ad2c4c7fe82914c1829a4c771fef9e09..987159f4d325fba41878f82dec4cd6825a8e6b63 100644

--- a/public/platform/WebMediaPlayerClient.h

+++ b/public/platform/WebMediaPlayerClient.h

@@ -83,7 +83,9 @@ public:

virtual void keyAdded(const WebString& keySystem, const WebString& sessionId) = 0;

virtual void keyError(const WebString& keySystem, const WebString& sessionId, MediaKeyErrorCode, unsigned short systemCode) = 0;

virtual void keyMessage(const WebString& keySystem, const WebString& sessionId, const unsigned char* message, unsigned messageLength, const WebURL& defaultURL) = 0;

- virtual void keyNeeded(const WebString& contentType, const unsigned char* initData, unsigned initDataLength) = 0;

+ // FIXME: Remove keyNeeded() once rename to encrypted() is complete.

+ virtual void keyNeeded(const WebString& contentType, const unsigned char* initData, unsigned initDataLength) OVERRIDE;

Mike West 2014/09/30 19:27:11 What is this overriding? WebMediaPlayerClient does

sandersd (OOO until July 31) 2014/09/30 19:39:12 Whoops, C&P error, thanks!

+ virtual void encrypted(const WebString& initDataType, const unsigned char* initData, unsigned initDataLength) OVERRIDE;

virtual void setWebLayer(WebLayer*) = 0;

virtual WebMediaPlayer::TrackId addAudioTrack(const WebString& id, AudioTrackKind, const WebString& label, const WebString& language, bool enabled) = 0;

virtual void removeAudioTrack(WebMediaPlayer::TrackId) = 0;

« no previous file with comments | « Source/web/WebMediaPlayerClientImpl.cpp ('k') | no next file » | no next file with comments »