Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 600073002: Docserver: Run tasks in testing (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Run tasks in testing The old fake taskqueue just discarded all tasks. This of course broke integration tests because refresh tasks never ran and the in-memory memcache never got populated. This changes the fake taskqueue so that it just executes queued tasks immediately and synchronously. BUG=None TBR=kalman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/514a552f623f3934dc602b6d73539226e16475eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M chrome/common/extensions/docs/server2/appengine_wrappers.py View 1 chunk +20 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/integration_test.py View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/servlet.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/514a552f623f3934dc602b6d73539226e16475eb Cr-Commit-Position: refs/heads/master@{#296480}
6 years, 3 months ago (2014-09-24 18:54:42 UTC) #1
Ken Rockot(use gerrit already)
6 years, 3 months ago (2014-09-24 18:55:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 514a552.

Powered by Google App Engine
This is Rietveld 408576698