Issue 60006: Fix linux crash on opening new tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60006: Fix linux crash on opening new tab. (Closed)

Created:
11 years, 8 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove an #if !defined(OS_LINUX) Fixes a linux crash on opening a new tab, because without this code, the render process sends a page_id of 1 to the browser process, which crashes in NavigationController::ClassifyNavigation since page_id==1 is not higher than the max page id (when you've already surfed to another page in a previous tab), so the NavigationController crashes on trying to look up an entry for the page which doesn't exist. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12954

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome/renderer/render_thread.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages