[GCM] Loading the account mappings from store to the driver

Loading the account mappings from store to the driver.
This is to make sure the starting list of account
mapping properly reflects the mappings present in the
previous Chrome session.

BUG=374969
Committed: https://crrev.com/d578c18be6220adb21d8e1261c9196cc27c4a879
Cr-Commit-Position: refs/heads/master@{#296567}

[fgorski, 2014-09-24 19:56:36]

fgorski@chromium.org changed reviewers:
+ jianli@chromium.org, zea@chromium.org

[fgorski, 2014-09-24 20:02:30]

PTAL

This change Loads the list of known account mappings from the GCM Store on GCM
client load and delivers it to the GCMDriver.OnGCMReady event.

zea: gcm_store
jianli: gcm_driver

But please feel free to cover the whole change.

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client_impl_unittest.cc (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client_impl_unittest.cc:498: // Ignore account
mappings for now.
Change to a TODO:

https://codereview.chromium.org/600053002/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store.h (right):

https://codereview.chromium.org/600053002/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store.h:37: // Map of account id to account info for
account mappings.
Fix documentation

[Nicolas Zea, 2014-09-24 20:10:05]

LGTM. Mind expanding the commit description, so its clear that this is a GCM
change?

[jianli, 2014-09-24 21:21:31]

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/BUILD.gn
File components/gcm_driver/BUILD.gn (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/BUILD....
components/gcm_driver/BUILD.gn:14: "gcm_account_mapper.cc",
should these 2 files be excluded from Android target?

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client.h (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client.h:204: // |account_mappings|: a list of
accounts mapped to this GCM client.
nit: a list of persisted accounts ...

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client_impl.cc (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client_impl.cc:325:
account_mappings.swap(result->account_mappings);
Why can't we pass result->account_mappings to OnReady?

[fgorski, 2014-09-24 22:25:40]

Jian, all comments addressed.

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/BUILD.gn
File components/gcm_driver/BUILD.gn (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/BUILD....
components/gcm_driver/BUILD.gn:14: "gcm_account_mapper.cc",
On 2014/09/24 21:21:31, jianli wrote:
> should these 2 files be excluded from Android target?

No GMS Core handles that on Android, and we don't need to introduce the mapper
over there.

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client.h (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client.h:204: // |account_mappings|: a list of
accounts mapped to this GCM client.
On 2014/09/24 21:21:31, jianli wrote:
> nit: a list of persisted accounts ...

Done.

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client_impl.cc (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client_impl.cc:325:
account_mappings.swap(result->account_mappings);
On 2014/09/24 21:21:31, jianli wrote:
> Why can't we pass result->account_mappings to OnReady?

Added comment as discussed.

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
File components/gcm_driver/gcm_client_impl_unittest.cc (right):

https://codereview.chromium.org/600053002/diff/1/components/gcm_driver/gcm_cl...
components/gcm_driver/gcm_client_impl_unittest.cc:498: // Ignore account
mappings for now.
On 2014/09/24 20:02:30, fgorski wrote:
> Change to a TODO:

Done.

https://codereview.chromium.org/600053002/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store.h (right):

https://codereview.chromium.org/600053002/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store.h:37: // Map of account id to account info for
account mappings.
On 2014/09/24 20:02:30, fgorski wrote:
> Fix documentation

Done.

[jianli, 2014-09-24 22:32:17]

lgtm

[fgorski, 2014-09-24 22:33:39]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-09-24 22:34:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600053002/40001

[commit-bot: I haz the power, 2014-09-24 23:40:24]

Committed patchset #3 (id:40001) as 5c1ce944a32e0bbb61e743bb998e06db5dfaace5

[commit-bot: I haz the power, 2014-09-24 23:47:12]

Patchset 3 (id:??) landed as
https://crrev.com/d578c18be6220adb21d8e1261c9196cc27c4a879
Cr-Commit-Position: refs/heads/master@{#296567}