Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/global_packages.dart

Issue 599993004: Don't load transformers that aren't going to be used for an executable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart b/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
index c09cf612ff1138bafd0305591190f32d2b72534b..4c4a01adc67b713b0897b53fdd2983cd1163f822 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/global_packages.dart
@@ -226,25 +226,35 @@ class GlobalPackages {
try {
var binDir = p.join(_directory, package, 'bin');
cleanDir(binDir);
- AssetEnvironment.create(
- entrypoint,
- BarbackMode.RELEASE,
- useDart2JS: false).then((x0) {
+ entrypoint.loadPackageGraph().then((x0) {
try {
- var environment = x0;
- environment.barback.errors.listen(((error) {
- log.error(log.red("Build error:\n$error"));
- }));
- completer0.complete(
- environment.precompileExecutables(package, binDir));
+ var graph = x0;
+ AssetEnvironment.create(
+ entrypoint,
+ BarbackMode.RELEASE,
+ entrypoints: graph.packages[package].executableIds,
+ useDart2JS: false).then((x1) {
+ try {
+ var environment = x1;
+ environment.barback.errors.listen(((error) {
+ log.error(log.red("Build error:\n$error"));
+ }));
+ completer0.complete(
+ environment.precompileExecutables(package, binDir));
+ } catch (e1) {
+ completer0.completeError(e1);
+ }
+ }, onError: (e2) {
+ completer0.completeError(e2);
+ });
} catch (e0) {
completer0.completeError(e0);
}
- }, onError: (e1) {
- completer0.completeError(e1);
+ }, onError: (e3) {
+ completer0.completeError(e3);
});
- } catch (e2) {
- completer0.completeError(e2);
+ } catch (e4) {
+ completer0.completeError(e4);
}
});
return completer0.future;

Powered by Google App Engine
This is Rietveld 408576698