Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart

Issue 599993004: Don't load transformers that aren't going to be used for an executable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart
index 4f760357a362d832588b90907601aa10e4f3c4d8..8ab13b2125a4e1ed7f7a910395105d57e002416b 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/load_all_transformers.dart
@@ -1,167 +1,196 @@
library pub.load_all_transformers;
import 'dart:async';
+import 'package:barback/barback.dart';
import '../log.dart' as log;
import '../package_graph.dart';
import '../utils.dart';
import 'asset_environment.dart';
import 'barback_server.dart';
+import 'dependency_computer.dart';
import 'transformer_id.dart';
import 'transformer_loader.dart';
-import 'transformers_needed_by_transformers.dart';
Future loadAllTransformers(AssetEnvironment environment,
- BarbackServer transformerServer) {
+ BarbackServer transformerServer, {Iterable<AssetId> entrypoints}) {
final completer0 = new Completer();
scheduleMicrotask(() {
try {
- var transformersNeededByTransformers =
- computeTransformersNeededByTransformers(environment.graph);
- var buffer = new StringBuffer();
- buffer.writeln("Transformer dependencies:");
- transformersNeededByTransformers.forEach(((id, dependencies) {
- if (dependencies.isEmpty) {
- buffer.writeln("$id: -");
- } else {
- buffer.writeln("$id: ${toSentence(dependencies)}");
- }
- }));
- log.fine(buffer);
- var stagedTransformers =
- _stageTransformers(transformersNeededByTransformers);
- var packagesThatUseTransformers =
- _packagesThatUseTransformers(environment.graph);
- var loader = new TransformerLoader(environment, transformerServer);
- join0(x0) {
- var cache = x0;
- var first = true;
- var it0 = stagedTransformers.iterator;
- break0(x6) {
- join1() {
- Future.wait(environment.graph.packages.values.map(((package) {
- final completer0 = new Completer();
- scheduleMicrotask(() {
- try {
- loader.transformersForPhases(
- package.pubspec.transformers).then((x0) {
- try {
- var phases = x0;
- var transformers =
- environment.getBuiltInTransformers(package);
- join0() {
- join1() {
- newFuture(
- (() => environment.barback.updateTransformers(package.name, phases)));
- completer0.complete(null);
- }
- if (phases.isEmpty) {
- completer0.complete(null);
- } else {
- join1();
- }
- }
- if (transformers != null) {
- phases.add(transformers);
- join0();
- } else {
- join0();
- }
- } catch (e0) {
- completer0.completeError(e0);
- }
- }, onError: (e1) {
- completer0.completeError(e1);
- });
- } catch (e2) {
- completer0.completeError(e2);
- }
- });
- return completer0.future;
- }))).then((x1) {
- try {
- x1;
- completer0.complete(null);
- } catch (e0) {
- completer0.completeError(e0);
- }
- }, onError: (e1) {
- completer0.completeError(e1);
- });
- }
- if (cache != null) {
- cache.save();
- join1();
+ var dependencyComputer = new DependencyComputer(environment.graph);
+ var necessaryTransformers;
+ join0() {
+ var transformersNeededByTransformers =
+ dependencyComputer.transformersNeededByTransformers(necessaryTransformers);
+ var buffer = new StringBuffer();
+ buffer.writeln("Transformer dependencies:");
+ transformersNeededByTransformers.forEach(((id, dependencies) {
+ if (dependencies.isEmpty) {
+ buffer.writeln("$id: -");
} else {
- join1();
+ buffer.writeln("$id: ${toSentence(dependencies)}");
}
- }
- continue0(x7) {
- if (it0.moveNext()) {
- Future.wait([]).then((x5) {
- var stage = it0.current;
- join2(x2) {
- var snapshotPath = x2;
- first = false;
- loader.load(stage, snapshot: snapshotPath).then((x3) {
+ }));
+ log.fine(buffer);
+ var stagedTransformers =
+ _stageTransformers(transformersNeededByTransformers);
+ var packagesThatUseTransformers =
+ _packagesThatUseTransformers(environment.graph);
+ var loader = new TransformerLoader(environment, transformerServer);
+ join1(x0) {
+ var cache = x0;
+ var first = true;
+ var it0 = stagedTransformers.iterator;
+ break0(x6) {
+ join2() {
+ Future.wait(environment.graph.packages.values.map(((package) {
+ final completer0 = new Completer();
+ scheduleMicrotask(() {
try {
- x3;
- var packagesToUpdate =
- unionAll(stage.map(((id) => packagesThatUseTransformers[id])));
- Future.wait(packagesToUpdate.map(((packageName) {
- final completer0 = new Completer();
- scheduleMicrotask(() {
- try {
- var package = environment.graph.packages[packageName];
- loader.transformersForPhases(
- package.pubspec.transformers).then((x0) {
- try {
- var phases = x0;
- environment.barback.updateTransformers(
- packageName,
- phases);
- completer0.complete(null);
- } catch (e0) {
- completer0.completeError(e0);
- }
- }, onError: (e1) {
- completer0.completeError(e1);
- });
- } catch (e2) {
- completer0.completeError(e2);
- }
- });
- return completer0.future;
- }))).then((x4) {
+ loader.transformersForPhases(
+ package.pubspec.transformers).then((x0) {
try {
- x4;
- continue0(null);
- } catch (e3) {
- completer0.completeError(e3);
+ var phases = x0;
+ var transformers =
+ environment.getBuiltInTransformers(package);
+ join0() {
+ join1() {
+ newFuture(
+ (() => environment.barback.updateTransformers(package.name, phases)));
+ completer0.complete(null);
+ }
+ if (phases.isEmpty) {
+ completer0.complete(null);
+ } else {
+ join1();
+ }
+ }
+ if (transformers != null) {
+ phases.add(transformers);
+ join0();
+ } else {
+ join0();
+ }
+ } catch (e0) {
+ completer0.completeError(e0);
}
- }, onError: (e4) {
- completer0.completeError(e4);
+ }, onError: (e1) {
+ completer0.completeError(e1);
});
} catch (e2) {
completer0.completeError(e2);
}
- }, onError: (e5) {
- completer0.completeError(e5);
});
- }
- if (cache == null || !first) {
- join2(null);
- } else {
- join2(cache.snapshotPath(stage));
- }
- });
- } else {
- break0(null);
+ return completer0.future;
+ }))).then((x1) {
+ try {
+ x1;
+ completer0.complete(null);
+ } catch (e0) {
+ completer0.completeError(e0);
+ }
+ }, onError: (e1) {
+ completer0.completeError(e1);
+ });
+ }
+ if (cache != null) {
+ cache.save();
+ join2();
+ } else {
+ join2();
+ }
}
+ continue0(x7) {
+ if (it0.moveNext()) {
+ Future.wait([]).then((x5) {
+ var stage = it0.current;
+ join3(x2) {
+ var snapshotPath = x2;
+ first = false;
+ loader.load(stage, snapshot: snapshotPath).then((x3) {
+ try {
+ x3;
+ var packagesToUpdate =
+ unionAll(stage.map(((id) => packagesThatUseTransformers[id])));
+ Future.wait(packagesToUpdate.map(((packageName) {
+ final completer0 = new Completer();
+ scheduleMicrotask(() {
+ try {
+ var package =
+ environment.graph.packages[packageName];
+ loader.transformersForPhases(
+ package.pubspec.transformers).then((x0) {
+ try {
+ var phases = x0;
+ environment.barback.updateTransformers(
+ packageName,
+ phases);
+ completer0.complete(null);
+ } catch (e0) {
+ completer0.completeError(e0);
+ }
+ }, onError: (e1) {
+ completer0.completeError(e1);
+ });
+ } catch (e2) {
+ completer0.completeError(e2);
+ }
+ });
+ return completer0.future;
+ }))).then((x4) {
+ try {
+ x4;
+ continue0(null);
+ } catch (e3) {
+ completer0.completeError(e3);
+ }
+ }, onError: (e4) {
+ completer0.completeError(e4);
+ });
+ } catch (e2) {
+ completer0.completeError(e2);
+ }
+ }, onError: (e5) {
+ completer0.completeError(e5);
+ });
+ }
+ if (cache == null || !first) {
+ join3(null);
+ } else {
+ join3(cache.snapshotPath(stage));
+ }
+ });
+ } else {
+ break0(null);
+ }
+ }
+ continue0(null);
+ }
+ if (environment.rootPackage.dir == null) {
+ join1(null);
+ } else {
+ join1(environment.graph.loadTransformerCache());
}
- continue0(null);
}
- if (environment.rootPackage.dir == null) {
- join0(null);
+ if (entrypoints != null) {
+ join4() {
+ necessaryTransformers =
+ unionAll(entrypoints.map(dependencyComputer.transformersNeededByLibrary));
+ join5() {
+ join0();
+ }
+ if (necessaryTransformers.isEmpty) {
+ log.fine(
+ "No transformers are needed for ${toSentence(entrypoints)}.");
+ completer0.complete(null);
+ } else {
+ join5();
+ }
+ }
+ if (entrypoints.isEmpty) {
+ completer0.complete(null);
+ } else {
+ join4();
+ }
} else {
- join0(environment.graph.loadTransformerCache());
+ join0();
}
} catch (e6) {
completer0.completeError(e6);

Powered by Google App Engine
This is Rietveld 408576698