Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart

Issue 599993004: Don't load transformers that aren't going to be used for an executable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart b/sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart
index a7cd3d549a6c316b8fea24835db9b7e34ee03d3e..12777695cbc097c9e0ce6df95761b06eb46f27eb 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart
@@ -24,7 +24,8 @@ import 'source_directory.dart';
class AssetEnvironment {
static Future<AssetEnvironment> create(Entrypoint entrypoint,
BarbackMode mode, {WatcherType watcherType, String hostname, int basePort,
- Iterable<String> packages, bool useDart2JS: true}) {
+ Iterable<String> packages, Iterable<AssetId> entrypoints, bool useDart2JS:
+ true}) {
if (watcherType == null) watcherType = WatcherType.NONE;
if (hostname == null) hostname = "localhost";
if (basePort == null) basePort = 0;
@@ -35,7 +36,9 @@ class AssetEnvironment {
barback.log.listen(_log);
var environment =
new AssetEnvironment._(graph, barback, mode, watcherType, hostname, basePort);
- return environment._load(useDart2JS: useDart2JS).then((_) => environment);
+ return environment._load(
+ entrypoints: entrypoints,
+ useDart2JS: useDart2JS).then((_) => environment);
});
}
static PackageGraph _adjustPackageGraph(PackageGraph graph, BarbackMode mode,
@@ -313,7 +316,7 @@ class AssetEnvironment {
barback.updateSources(_modifiedSources);
_modifiedSources = null;
}
- Future _load({bool useDart2JS}) {
+ Future _load({Iterable<AssetId> entrypoints, bool useDart2JS}) {
return log.progress("Initializing barback", () {
var containsDart2JS = graph.entrypoint.root.pubspec.transformers.any(
(transformers) =>
@@ -354,7 +357,8 @@ class AssetEnvironment {
return log.progress("Loading transformers", () {
return loadAllTransformers(
this,
- transformerServer).then((_) => transformerServer.close());
+ transformerServer,
+ entrypoints: entrypoints).then((_) => transformerServer.close());
}, fine: true);
}, [errorStream, barback.results, transformerServer.results]);
});

Powered by Google App Engine
This is Rietveld 408576698