sdk/lib/_internal/pub/lib/src/entrypoint.dart - Issue 599993004: Don't load transformers that aren't going to be used for an executable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/entrypoint.dart

Issue 599993004: Don't load transformers that aren't going to be used for an executable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback/transformers_needed_by_transformers.dart ('k') | sdk/lib/_internal/pub/lib/src/executable.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/entrypoint.dart

diff --git a/sdk/lib/_internal/pub/lib/src/entrypoint.dart b/sdk/lib/_internal/pub/lib/src/entrypoint.dart

index 5f3f7d1a6c43466f5e5ae718142513555a11b4c1..f8717470fda2341c1c9246c9a99148151243979c 100644

--- a/sdk/lib/_internal/pub/lib/src/entrypoint.dart

+++ b/sdk/lib/_internal/pub/lib/src/entrypoint.dart

@@ -265,8 +265,11 @@ class Entrypoint {

var packagesToLoad =

unionAll(executables.keys.map(graph.transitiveDependencies))

.map((package) => package.name).toSet();

+ var executableIds = unionAll(

+ executables.values.map((ids) => ids.toSet()));

var environment = await AssetEnvironment.create(this, BarbackMode.RELEASE,

packages: packagesToLoad,

+ entrypoints: executableIds,

useDart2JS: false);

environment.barback.errors.listen((error) {

log.error(log.red("Build error:\n$error"));