Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 599993003: Add gtest_tests dictionaries for a single Linux debug tester. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add gtest_tests dictionaries for a single Linux debug tester. This has to be landed first. After the recipe change, I'll remove the old ones. BUG=414808 R=phajdan.jr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4d2bfd854ee6282d8a9af0722c205689d989001a

Patch Set 1 : #

Total comments: 3

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 1 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jam
6 years, 3 months ago (2014-09-24 21:41:40 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/599993003/diff/20001/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/599993003/diff/20001/testing/buildbot/chromium.linux.json#newcode2 testing/buildbot/chromium.linux.json:2: "Linux Tests": { We already have "Linux Tests" here.
6 years, 3 months ago (2014-09-24 22:18:18 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/599993003/diff/20001/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/599993003/diff/20001/testing/buildbot/chromium.linux.json#newcode167 testing/buildbot/chromium.linux.json:167: "Linux Tests": { This should probably be "Linux Tests ...
6 years, 3 months ago (2014-09-24 22:19:53 UTC) #5
jam
https://codereview.chromium.org/599993003/diff/20001/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/599993003/diff/20001/testing/buildbot/chromium.linux.json#newcode167 testing/buildbot/chromium.linux.json:167: "Linux Tests": { On 2014/09/24 22:19:53, Paweł Hajdan Jr. ...
6 years, 3 months ago (2014-09-24 22:24:20 UTC) #6
Paweł Hajdan Jr.
LGTM
6 years, 3 months ago (2014-09-24 23:50:30 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4d2bfd854ee6282d8a9af0722c205689d989001a Cr-Commit-Position: refs/heads/master@{#296577}
6 years, 3 months ago (2014-09-24 23:53:57 UTC) #8
jam
Committed patchset #2 (id:40001) manually as 4d2bfd8 (presubmit successful).
6 years, 3 months ago (2014-09-24 23:54:02 UTC) #9
jam
6 years, 2 months ago (2014-09-29 05:35:22 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/610943002/ by jam@chromium.org.

The reason for reverting is: reverting per new approach I'm taking in
https://codereview.chromium.org/602963002/.

Powered by Google App Engine
This is Rietveld 408576698