Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 599973002: Revert of [Athena, Cleanup] rename WidnowManager::GetInstance -> ::Get (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Athena, Cleanup] rename WidnowManager::GetInstance -> ::Get (patchset #1 id:40001 of https://codereview.chromium.org/599683003/) Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36880 AthenaEnvTest.TerminatingCallback and DragHandleTest.ScrollTest started failing; this CL sounds related. Speculatively reverting. Original issue's description: > rename WidnowManager::GetInstance -> ::Get > call OnTerminating in unit test. > > BUG=None > > Committed: https://crrev.com/828338e278350941febbfbede2b34d721be6dab1 > Cr-Commit-Position: refs/heads/master@{#296348} TBR=mukai@chromium.org,skuhne@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -50 lines) Patch
M athena/activity/activity_frame_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/content/app_activity.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/app_activity_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/app_activity_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/home_card_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M athena/home/home_card_unittest.cc View 15 chunks +20 lines, -19 lines 0 comments Download
M athena/resource_manager/resource_manager_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M athena/resource_manager/resource_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/test/athena_test_base.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M athena/wm/public/window_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/test/window_manager_impl_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_manager_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
Created Revert of [Athena, Cleanup] rename WidnowManager::GetInstance -> ::Get
6 years, 3 months ago (2014-09-24 15:34:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599973002/1
6 years, 3 months ago (2014-09-24 15:35:27 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 15:36:10 UTC) #4
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698