Issue 599963002: Use OptDrawState instead of DrawState when flushing state in GrGpuGL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 599963002: Use OptDrawState instead of DrawState when flushing state in GrGpuGL (Closed)

Created:
6 years, 3 months ago by egdaniel

Modified:
6 years, 3 months ago

Reviewers:
joshualitt, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Use OptDrawState instead of DrawState when flushing state in GrGpuGL BUG=skia: Committed: https://skia.googlesource.com/skia/+/d632ea4b9eec5be3f83a9fa4982a30202e1239a7

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -22 lines)			Patch
M	src/gpu/gl/GrGpuGL.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	8 chunks	+12 lines, -16 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

egdaniel

Some leftover cases where the original GrDrawState was still being used on the gl side ...

6 years, 3 months ago (2014-09-24 15:16:28 UTC) #2

joshua.litt

On 2014/09/24 15:16:28, egdaniel wrote: > Some leftover cases where the original GrDrawState was still ...

6 years, 3 months ago (2014-09-24 16:03:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599963002/1

6 years, 3 months ago (2014-09-24 17:22:01 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 17:30:17 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as d632ea4b9eec5be3f83a9fa4982a30202e1239a7