Issue 59993003: DevTools: add title to computed fonts section

Issue 59993003: DevTools: add title to computed fonts section (Closed)

Created:
7 years, 1 month ago by lushnikov

Modified:
7 years, 1 month ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: add title to computed fonts section This patch adds a title to computed fonts section. Note that it also removes computed css font value from it. See bug for screenshot related to this UI change. BUG=315118 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161371

Patch Set 1 #

Patch Set 2 : small refactoring #

Patch Set 3 : fix borders glitch #

Total comments: 2

Patch Set 4 : fixing nits #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	Source/devtools/front_end/PlatformFontsSidebarPane.js	View	1 2 3	2 chunks	+8 lines, -9 lines	0 comments	Download
	M	Source/devtools/front_end/elementsPanel.css	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsevik

https://chromiumcodereview.appspot.com/59993003/diff/90001/Source/devtools/front_end/PlatformFontsSidebarPane.js File Source/devtools/front_end/PlatformFontsSidebarPane.js (right): https://chromiumcodereview.appspot.com/59993003/diff/90001/Source/devtools/front_end/PlatformFontsSidebarPane.js#newcode43 Source/devtools/front_end/PlatformFontsSidebarPane.js:43: this._sectionTitle = document.createElement("div"); consider document.createElementwithClass https://chromiumcodereview.appspot.com/59993003/diff/90001/Source/devtools/front_end/elementsPanel.css File Source/devtools/front_end/elementsPanel.css (right): ...

7 years, 1 month ago (2013-11-05 17:30:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/59993003/140001

7 years, 1 month ago (2013-11-05 17:33:30 UTC) #6

Message was sent while issue was closed.

Change committed as 161371

Expand Messages | Collapse Messages