Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 599913002: Have nanobench --verbose mode always just print integer nanoseconds. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
tfarina, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Have nanobench --verbose mode always just print integer nanoseconds. Don't know that anyone but me is using this. Speak up now! BUG=skia: NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/dc5bbab138bfffc85d6ba525d990aad09c322ff6

Patch Set 1 #

Total comments: 1

Patch Set 2 : More natural integration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M bench/nanobench.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599913002/1
6 years, 3 months ago (2014-09-24 13:16:46 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-24 13:16:47 UTC) #3
tfarina
lgtm https://codereview.chromium.org/599913002/diff/1/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/599913002/diff/1/bench/nanobench.cpp#newcode681 bench/nanobench.cpp:681: SkDebugf("%lld ", (uint64_t)(samples[i] * 1000000)); looks fine.
6 years, 3 months ago (2014-09-24 13:22:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599913002/20001
6 years, 3 months ago (2014-09-24 13:23:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599913002/20001
6 years, 3 months ago (2014-09-24 13:34:06 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 13:34:34 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as dc5bbab138bfffc85d6ba525d990aad09c322ff6

Powered by Google App Engine
This is Rietveld 408576698