chrome/utility/image_writer/image_writer.cc - Issue 599853002: [Mac] Use raw disks (/dev/rdisk#) in image_writer_mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/image_writer/image_writer.cc

Issue 599853002: [Mac] Use raw disks (/dev/rdisk#) in image_writer_mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a DCHECK in WriteChunk. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/utility/image_writer/image_writer.cc

diff --git a/chrome/utility/image_writer/image_writer.cc b/chrome/utility/image_writer/image_writer.cc

index 65994dbcb6a89fe8b9178443e1fcbe7f21b4feda..2a2b8a1c5d62cb348351429ecfb38ec802df4ea6 100644

--- a/chrome/utility/image_writer/image_writer.cc

+++ b/chrome/utility/image_writer/image_writer.cc

@@ -125,6 +125,7 @@ void ImageWriter::WriteChunk() {

// aligned writes to devices.

int bytes_to_write = bytes_read + (kMemoryAlignment - 1) -

(bytes_read - 1) % kMemoryAlignment;

+ DCHECK_EQ(0, bytes_to_write % kMemoryAlignment);

int bytes_written =

device_file_.Write(bytes_processed_, buffer.get(), bytes_to_write);

« no previous file with comments | « no previous file | chrome/utility/image_writer/image_writer_mac.cc » ('j') | no next file with comments »