Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 59983002: Refactor TimelineOverview to make squeezing impl-side frames easier (Closed)

Created:
7 years, 1 month ago by caseq
Modified:
7 years, 1 month ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Refactor TimelineOverview to make squeezing impl-side frames easier This makes some of TimelineFrameOverview members easier to reuse by removing side effects and dependency on the class state. BUG=305863 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161634

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed zoomToWindow() #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -58 lines) Patch
M Source/devtools/front_end/TimelineOverviewPane.js View 1 10 chunks +62 lines, -58 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
7 years, 1 month ago (2013-11-05 14:46:30 UTC) #1
vsevik
lgtm
7 years, 1 month ago (2013-11-06 07:09:54 UTC) #2
vsevik
https://chromiumcodereview.appspot.com/59983002/diff/1/Source/devtools/front_end/TimelineOverviewPane.js File Source/devtools/front_end/TimelineOverviewPane.js (right): https://chromiumcodereview.appspot.com/59983002/diff/1/Source/devtools/front_end/TimelineOverviewPane.js#newcode705 Source/devtools/front_end/TimelineOverviewPane.js:705: var duration = frames[currentFrame].duration; wrong indent
7 years, 1 month ago (2013-11-06 07:13:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/59983002/150001
7 years, 1 month ago (2013-11-08 16:23:02 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 17:44:53 UTC) #5
Message was sent while issue was closed.
Change committed as 161634

Powered by Google App Engine
This is Rietveld 408576698