Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 599793002: Do not present poof animation while drag & drop a bookmark in the chevron-menu. (Closed)

Created:
6 years, 3 months ago by Gaja
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not present poof animation while drag & drop a bookmark in the chevron-menu. For offTheSideButton, animation was always enabled regardless of nodeMoved/ nodeRemoved. Enable animation only when it is called from -nodeRemoved:, decided by 'animate' parameter. BUG=60628 R=asvitkine@chromium.org TEST= 1. Launch chrome and add more bookmarks and folders so that chevron is seen. 2. Drag and adjust items so that there is atleast one folder and one or more bookmarks under chevron. 3. Drag a bookmark(within chevron) and drop it under the folder(within chevron) and observe. 4. There should be no poof animation/sound presented to see/hear. Committed: https://crrev.com/67f01ddf1bc44927cbe10bcc000bf8eec462c1fc Cr-Commit-Position: refs/heads/master@{#297105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Gaja
@asvitkine PTAL.
6 years, 3 months ago (2014-09-24 06:15:27 UTC) #1
Gaja
On 2014/09/24 06:15:27, Gajendra N wrote: > @asvitkine > PTAL. PTAL.
6 years, 2 months ago (2014-09-25 17:54:38 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-26 15:05:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599793002/1
6 years, 2 months ago (2014-09-27 05:00:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3a558f26eca26423cf59dfc7e6779e882436b100
6 years, 2 months ago (2014-09-27 05:49:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 05:50:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67f01ddf1bc44927cbe10bcc000bf8eec462c1fc
Cr-Commit-Position: refs/heads/master@{#297105}

Powered by Google App Engine
This is Rietveld 408576698