Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 599763003: Focus the contents of popup windows (Closed)

Created:
6 years, 2 months ago by stevenjb
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Focus the contents of popup windows After we show and activate a popup window from a user gesture, we should always focus the web contents. BUG=411332 Committed: https://crrev.com/a92701cc81a54f25bc36510288353b47ac31a34d Cr-Commit-Position: refs/heads/master@{#297305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/ui/browser_navigator.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stevenjb
I was looking for a way to test this, but: a) IsActive() is not reliable ...
6 years, 2 months ago (2014-09-26 18:27:39 UTC) #2
stevenjb
Ping. We'd like to fix this for 38.
6 years, 2 months ago (2014-09-29 22:03:26 UTC) #3
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-09-29 22:35:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599763003/1
6 years, 2 months ago (2014-09-29 22:37:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 131fcbb1ae843a8c13f94ad712df1db3aa6a2794
6 years, 2 months ago (2014-09-29 23:41:22 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 23:42:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a92701cc81a54f25bc36510288353b47ac31a34d
Cr-Commit-Position: refs/heads/master@{#297305}

Powered by Google App Engine
This is Rietveld 408576698