Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 599733007: Allow passing listening socket path on command line (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow passing listening socket path on command line When enabling externally-running applications, allow the user to specify a path for the listening socket. This makes development easier while still allowing for a default to be used in production. BUG=None TEST=run mojo_shell with --enable-external-applications=path/to/socket, without the flag, and with the flag but passing no value. Committed: https://crrev.com/774d386084e8cf996074ec1fa513e19a1cc1be62 Cr-Commit-Position: refs/heads/master@{#297247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M mojo/shell/context.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Chris Masone
PTAL
6 years, 2 months ago (2014-09-29 20:17:05 UTC) #2
DaveMoore
lgtm
6 years, 2 months ago (2014-09-29 20:20:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599733007/1
6 years, 2 months ago (2014-09-29 20:27:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4c7909794370733c259c324ebd4a876e1f7889a6
6 years, 2 months ago (2014-09-29 20:32:43 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 20:33:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/774d386084e8cf996074ec1fa513e19a1cc1be62
Cr-Commit-Position: refs/heads/master@{#297247}

Powered by Google App Engine
This is Rietveld 408576698