Issue 599733005: Merge 181302 "Tell synthetic attribute nodes inside shadow DOM a..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 599733005: Merge 181302 "Tell synthetic attribute nodes inside shadow DOM a..." (Closed)

Created:
6 years, 2 months ago by Sami

Modified:
6 years, 2 months ago

Reviewers:
Sami

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2125/

Project:
blink

Visibility:
Public.

More Reviews

Description

Merge 181302 "Tell synthetic attribute nodes inside shadow DOM a..." > Tell synthetic attribute nodes inside shadow DOM about move to new Document > > Node::didMoveToNewDocument() is called to notify a Node that it has > been moved under a new Document. This patch fixes a bug in > TreeScopeAdopter where this notification was not done for synthetic > attribute nodes inside a shadow DOM. The bug caused an issue where an > event handler registered for an attribute node was not correctly > unregistered when the parent element was moved to a new document. > > BUG=407477 > > Review URL: https://codereview.chromium.org/519003003 TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182750

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, --2 lines)			Patch
A +	LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/events/event-listener-on-attribute-inside-shadow-dom-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/dom/TreeScopeAdopter.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r182750.

Expand Messages | Collapse Messages