Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 599733002: StartPage/EndPage from spooling code. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

StartPage/EndPage from spooling code. Calling this from metafiles unreliable. For example it's not played if for empty page metafiles. Removed multipage support from windows metafile. We never use that, but it cause issues with empty files. BUG=412690 Committed: https://crrev.com/71c46df98f27676b71a5f6773855adc4a2d3eba8 Cr-Commit-Position: refs/heads/master@{#296337}

Patch Set 1 #

Patch Set 2 : Tue Sep 23 18:18:33 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -65 lines) Patch
M chrome/service/cloud_print/print_system_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/emf_win.h View 2 chunks +1 line, -5 lines 0 comments Download
M printing/emf_win.cc View 1 5 chunks +7 lines, -60 lines 0 comments Download
M printing/printed_document_win.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-24 01:20:05 UTC) #2
gene
lgtm
6 years, 3 months ago (2014-09-24 01:21:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599733002/20001
6 years, 3 months ago (2014-09-24 02:04:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9897cae50ac366fa861275bc77fc941eaf2e76b7
6 years, 3 months ago (2014-09-24 03:20:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 03:20:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71c46df98f27676b71a5f6773855adc4a2d3eba8
Cr-Commit-Position: refs/heads/master@{#296337}

Powered by Google App Engine
This is Rietveld 408576698