Issue 59973010: Android: Don't instantiate TextureImageTransportSurface

Issue 59973010: Android: Don't instantiate TextureImageTransportSurface (Closed)

Created:
7 years, 1 month ago by no sievers

Modified:
7 years, 1 month ago

Reviewers:
piman

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su, miu+watch_chromium.org, Sami

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: Don't instantiate TextureImageTransportSurface NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233164

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -37 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_android.cc	View		3 chunks	+2 lines, -37 lines	0 comments	Download
M	content/common/gpu/image_transport_surface.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/gpu/image_transport_surface_android.cc	View	1	1 chunk	+88 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM. I'll steal this surface from you eventually for Aura. https://codereview.chromium.org/59973010/diff/1/content/common/gpu/image_transport_surface_android.cc File content/common/gpu/image_transport_surface_android.cc (right): https://codereview.chromium.org/59973010/diff/1/content/common/gpu/image_transport_surface_android.cc#newcode82 ...

7 years, 1 month ago (2013-11-05 23:48:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/59973010/1

7 years, 1 month ago (2013-11-05 23:56:04 UTC) #3

commit-bot: I haz the power

Commit queue failed due to new patchset.

7 years, 1 month ago (2013-11-06 00:39:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/59973010/80001

7 years, 1 month ago (2013-11-06 00:42:42 UTC) #5

Message was sent while issue was closed.

Change committed as 233164

Expand Messages | Collapse Messages