Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 59973004: Revert "Handlify concat string and substring." (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Revert "Handlify concat string and substring." This reverts r17490. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -250 lines) Patch
M src/factory.h View 1 chunk +7 lines, -12 lines 0 comments Download
M src/factory.cc View 3 chunks +13 lines, -205 lines 0 comments Download
M src/handles.h View 1 chunk +1 line, -1 line 0 comments Download
M src/handles.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +256 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/runtime.cc View 4 chunks +19 lines, -17 lines 0 comments Download
M test/mjsunit/string-slices.js View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 1 month ago (2013-11-05 15:33:59 UTC) #1
Toon Verwaest
lgtm (rubberstamp)
7 years, 1 month ago (2013-11-05 15:34:56 UTC) #2
Yang
7 years, 1 month ago (2013-11-05 15:36:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17497.

Powered by Google App Engine
This is Rietveld 408576698