Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 59973002: Will now explicitly copy adapter.js into apprtc. (Closed)

Created:
7 years, 1 month ago by phoglund_chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Will now explicitly copy adapter.js into apprtc. It turns out shutil.copytree doesn't magically resolve symlinks like I thought, so we need to copy adapter.js explicitly in order to "resolve" the symlink on Windows. BUG=303021 R=kjellander@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M copy_apprtc.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
7 years, 1 month ago (2013-11-05 14:41:38 UTC) #1
kjellander_chromium
lgtm, but make sure to test on linux so the overwriting of the symlink there ...
7 years, 1 month ago (2013-11-05 14:44:37 UTC) #2
phoglund_chromium
On 2013/11/05 14:44:37, Henrik Kjellander wrote: > lgtm, but make sure to test on linux ...
7 years, 1 month ago (2013-11-05 14:46:20 UTC) #3
phoglund_chromium
7 years, 1 month ago (2013-11-05 14:46:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r232988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698