[Athena, Cleanup] rename WidnowManager::GetInstance -> ::Get

rename WidnowManager::GetInstance -> ::Get
call OnTerminating in unit test.

BUG=None

Committed: https://crrev.com/828338e278350941febbfbede2b34d721be6dab1
Cr-Commit-Position: refs/heads/master@{#296348}

Committed: https://crrev.com/978d46da0e03e72815548c995da800c23f5c61e4
Cr-Commit-Position: refs/heads/master@{#296448}

[oshima, 2014-09-23 22:53:39]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2014-09-23 22:53:53]

Patchset #2 (id:20001) has been deleted

[oshima, 2014-09-23 22:53:56]

Patchset #1 (id:1) has been deleted

[Jun Mukai, 2014-09-23 23:01:48]

mukai@chromium.org changed reviewers:
+ skuhne@chromium.org

[Jun Mukai, 2014-09-23 23:01:49]

looks good except for one part which needs to be reviewed by skuhne.
Also good to ping pkotwicz.

https://codereview.chromium.org/599683003/diff/40001/athena/resource_manager/...
File athena/resource_manager/resource_manager_impl.cc (right):

https://codereview.chromium.org/599683003/diff/40001/athena/resource_manager/...
athena/resource_manager/resource_manager_impl.cc:421:
WindowManager::Get()->GetWindowListProvider()->GetWindowList();
IIRC this intentionally doesn't use WindowListProvider, but I've forgotten why.
It's better to discuss with skuhne.

[Jun Mukai, 2014-09-23 23:20:08]

lgtm

https://codereview.chromium.org/599683003/diff/40001/athena/resource_manager/...
File athena/resource_manager/resource_manager_impl.cc (right):

https://codereview.chromium.org/599683003/diff/40001/athena/resource_manager/...
athena/resource_manager/resource_manager_impl.cc:421:
WindowManager::Get()->GetWindowListProvider()->GetWindowList();
On 2014/09/23 23:01:49, Jun Mukai wrote:
> IIRC this intentionally doesn't use WindowListProvider, but I've forgotten
why.
> It's better to discuss with skuhne.

chatted offline and this is actually a good move.  The reason is
WindowListProvider didn't exist at that point.

[Mr4D (OOO till 08-26), 2014-09-23 23:21:03]

lgtm for resource_manager_impl.

https://codereview.chromium.org/599683003/diff/40001/athena/resource_manager/...
File athena/resource_manager/resource_manager_impl.cc (right):

https://codereview.chromium.org/599683003/diff/40001/athena/resource_manager/...
athena/resource_manager/resource_manager_impl.cc:421:
WindowManager::Get()->GetWindowListProvider()->GetWindowList();
When this was written the WindowListProvider did not exist. I missed this one to
patch after adding the functionality. Thanks for changing!

[oshima, 2014-09-24 00:41:10]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599683003/40001

[commit-bot: I haz the power, 2014-09-24 00:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 00:45:46]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[oshima, 2014-09-24 04:34:49]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-24 04:35:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599683003/40001

[commit-bot: I haz the power, 2014-09-24 04:45:48]

Committed patchset #1 (id:40001) as 0f8a90032b0044d7197c950d5e3e5b516d6a12e9

[commit-bot: I haz the power, 2014-09-24 04:46:52]

Patchset 1 (id:??) landed as
https://crrev.com/828338e278350941febbfbede2b34d721be6dab1
Cr-Commit-Position: refs/heads/master@{#296348}

[phoglund_chromium, 2014-09-24 12:13:48]

A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/601753002/ by phoglund@chromium.org.

The reason for reverting is: Seems to cause crash in two tests; the crash is in
athena_test_base. Likely it isn't possible to call
AthenaEnv::Get()->OnTerminating(); in all cases.

Example:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

[Nico, 2014-09-24 15:34:59]

A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/599973002/ by thakis@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
AthenaEnvTest.TerminatingCallback  and DragHandleTest.ScrollTest started
failing; this CL sounds related. Speculatively reverting..

[oshima, 2014-09-24 16:44:58]

Patchset #2 (id:60001) has been deleted

[oshima, 2014-09-24 16:46:18]

On 2014/09/24 15:34:59, Nico (hiding) wrote:
> A revert of this CL (patchset #1 id:40001) has been created in
> https://codereview.chromium.org/599973002/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is:
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
> AthenaEnvTest.TerminatingCallback  and DragHandleTest.ScrollTest started
> failing; this CL sounds related. Speculatively reverting..

Thanks you for revert. There was a bug in the unit test and the above line was
catching it.
Unittest fixed, and relanding soon.

[oshima, 2014-09-24 16:47:47]

Patchset #2 (id:80001) has been deleted

[oshima, 2014-09-24 16:48:12]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-24 16:48:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599683003/100001

[commit-bot: I haz the power, 2014-09-24 17:28:11]

Committed patchset #2 (id:100001) as e12539627a06d7fa0e89ebf3d71c149d5c42299e

[commit-bot: I haz the power, 2014-09-24 17:28:51]

Patchset 2 (id:??) landed as
https://crrev.com/978d46da0e03e72815548c995da800c23f5c61e4
Cr-Commit-Position: refs/heads/master@{#296448}