Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 599683002: Add link to Settings page to add accessibility extensions. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ax_extensions
Project:
chromium
Visibility:
Public.

Description

Add link to Settings page to add accessibility extensions. See bug for more context; this makes the "Accessibility" section show up on all platforms, not just Chrome OS, and adds a link to the special web store page with curated accessibility extensions. BUG=416983 Committed: https://crrev.com/eb1d49a98d714ec2bcef8312a145f9eaba4e0a56 Cr-Commit-Position: refs/heads/master@{#296561}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -151 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 1 chunk +160 lines, -146 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dmazzoni
6 years, 3 months ago (2014-09-23 22:37:02 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/599683002/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/599683002/diff/1/chrome/browser/resources/options/browser_options.html#newcode718 chrome/browser/resources/options/browser_options.html:718: i18n-content="accessibilityFeaturesLink"></a> nit: <a href="https://chrome.google.com/webstore/category/collection/accessibility" id="accessibility-features" target="_blank" i18n-content="accessibilityFeaturesLink"></a> shaves ...
6 years, 3 months ago (2014-09-23 22:48:38 UTC) #3
dmazzoni
https://codereview.chromium.org/599683002/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/599683002/diff/1/chrome/browser/resources/options/browser_options.html#newcode718 chrome/browser/resources/options/browser_options.html:718: i18n-content="accessibilityFeaturesLink"></a> On 2014/09/23 22:48:37, Dan Beam wrote: > nit: ...
6 years, 3 months ago (2014-09-24 22:11:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599683002/20001
6 years, 3 months ago (2014-09-24 22:13:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b23adb155079b53f484e64febd7e998ec178b392
6 years, 3 months ago (2014-09-24 23:34:45 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:46:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb1d49a98d714ec2bcef8312a145f9eaba4e0a56
Cr-Commit-Position: refs/heads/master@{#296561}

Powered by Google App Engine
This is Rietveld 408576698