Remove old template html boilerplate

Remove old template html boilerplate

BUG=122753
TEST=navigate to madeupsite.com , error message should display normally

Committed: https://crrev.com/72b0e1130f19e8ffb95104ca0ce56c1cf828239e
Cr-Commit-Position: refs/heads/master@{#297078}

[Evan Stade, 2014-09-23 23:52:59]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2014-09-24 00:03:30]

lgtm w/nits

also, can you remove local_strings.js from
ui/webui/resources/js/compiled_resources.gyp?

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/about_sys/about_sys.js (right):

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/resources...
chrome/browser/resources/about_sys/about_sys.js:171: var templateData =
{'details': details};
nit: inline templateData

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc (right):

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc:679:
content::WebUIDataSource::Create(chrome::kChromeUINfcDebugHost);
nit: +\s\s

https://codereview.chromium.org/599653003/diff/40001/chrome/renderer/resource...
File chrome/renderer/resources/neterror.js (left):

https://codereview.chromium.org/599653003/diff/40001/chrome/renderer/resource...
chrome/renderer/resources/neterror.js:32: i18nTemplate.process(document,
strings);
^ does this already happen somewhere else and it was just happening again?

[Evan Stade, 2014-09-24 21:57:19]

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/about_sys/about_sys.js (right):

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/resources...
chrome/browser/resources/about_sys/about_sys.js:171: var templateData =
{'details': details};
On 2014/09/24 00:03:30, Dan Beam wrote:
> nit: inline templateData

I'm not really used to seeing inlined object declarations like that, so I'd
prefer not to unless you feel strongly.

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc (right):

https://codereview.chromium.org/599653003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc:679:
content::WebUIDataSource::Create(chrome::kChromeUINfcDebugHost);
On 2014/09/24 00:03:30, Dan Beam wrote:
> nit: +\s\s

Done.

https://codereview.chromium.org/599653003/diff/40001/chrome/renderer/resource...
File chrome/renderer/resources/neterror.js (left):

https://codereview.chromium.org/599653003/diff/40001/chrome/renderer/resource...
chrome/renderer/resources/neterror.js:32: i18nTemplate.process(document,
strings);
On 2014/09/24 00:03:30, Dan Beam wrote:
> ^ does this already happen somewhere else and it was just happening again?

Yea, it already happens at page startup; AFAICT there's no need to do it again
here.

[Evan Stade, 2014-09-24 21:58:52]

estade@chromium.org changed reviewers:
+ jochen@chromium.org, sky@chromium.org

[Evan Stade, 2014-09-24 21:58:53]

+owners

jochen:
  chrome/browser/chromeos/login/signin/merge_session_load_page.cc
  chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
  chrome/browser/ssl/ssl_blocking_page.cc
  chrome/browser/supervised_user/supervised_user_interstitial.cc
  chrome/renderer/resources/neterror.js
  components/dom_distiller/webui/dom_distiller_ui.cc
  content/browser/accessibility/accessibility_ui.cc
  content/browser/indexed_db/indexed_db_internals_ui.cc
  content/browser/service_worker/service_worker_internals_ui.cc
  content/public/browser/web_ui_data_source.h
sky:
  ui/base/webui/jstemplate_builder.cc
  ui/base/webui/jstemplate_builder.h

thanks!

[sky, 2014-09-24 23:24:38]

https://codereview.chromium.org/599653003/diff/60001/ui/base/webui/jstemplate...
File ui/base/webui/jstemplate_builder.cc (right):

https://codereview.chromium.org/599653003/diff/60001/ui/base/webui/jstemplate...
ui/base/webui/jstemplate_builder.cc:40: static const base::StringPiece
jstemplate_src(
Style guide says: "Objects with static storage duration, including global
variables, static variables, static class member variables, and function static
variables, must be Plain Old Data (POD): only ints, chars, floats, or pointers,
or arrays/structs of POD."

[Evan Stade, 2014-09-25 00:02:54]

https://codereview.chromium.org/599653003/diff/60001/ui/base/webui/jstemplate...
File ui/base/webui/jstemplate_builder.cc (right):

https://codereview.chromium.org/599653003/diff/60001/ui/base/webui/jstemplate...
ui/base/webui/jstemplate_builder.cc:40: static const base::StringPiece
jstemplate_src(
On 2014/09/24 23:24:37, sky wrote:
> Style guide says: "Objects with static storage duration, including global
> variables, static variables, static class member variables, and function
static
> variables, must be Plain Old Data (POD): only ints, chars, floats, or
pointers,
> or arrays/structs of POD."

I guess that copying a StringPiece is cheap, so I can just remove the |static|
here.

[sky, 2014-09-25 00:05:44]

LGTM

[jochen (gone - plz use gerrit), 2014-09-26 18:47:53]

rubberstamp lgtm

[Evan Stade, 2014-09-26 19:44:20]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-26 19:45:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599653003/120001

[commit-bot: I haz the power, 2014-09-26 20:08:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 20:08:15]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Evan Stade, 2014-09-26 21:48:04]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-26 21:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599653003/140001

[commit-bot: I haz the power, 2014-09-26 22:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 22:11:36]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Evan Stade, 2014-09-26 23:01:08]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-26 23:01:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/599653003/160001

[commit-bot: I haz the power, 2014-09-27 00:00:33]

Committed patchset #9 (id:160001) as 2bd85fc96cb03ccec92db3ad1e2b5546aadf81d8

[commit-bot: I haz the power, 2014-09-27 00:01:13]

Patchset 9 (id:??) landed as
https://crrev.com/72b0e1130f19e8ffb95104ca0ce56c1cf828239e
Cr-Commit-Position: refs/heads/master@{#297078}