Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 599633005: Gate the SRTPrompt on a specific FieldTrial group. (Closed)

Created:
6 years, 2 months ago by MAD
Modified:
6 years, 2 months ago
Reviewers:
waffles, csharp
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Gate the SRTPrompt on a specific FieldTrial group. Committed: https://crrev.com/c5fa39d5a7ec4f3d6034cd98dc9474f3a516f26a Cr-Commit-Position: refs/heads/master@{#296808}

Patch Set 1 : #

Patch Set 2 : Merged ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 4 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
MAD
Note that the metrics friendliness will go away as https://codereview.chromium.org/599653002 get committed and merged in. ...
6 years, 2 months ago (2014-09-25 19:30:21 UTC) #2
MAD
Since this is pretty small, adding OWNER reviewer right away... Thanks! BYE MAD
6 years, 2 months ago (2014-09-25 20:35:37 UTC) #5
csharp
lgtm
6 years, 2 months ago (2014-09-25 20:39:40 UTC) #6
waffles
lgtm
6 years, 2 months ago (2014-09-25 21:19:29 UTC) #7
MAD
On 2014/09/25 21:19:29, waffles wrote: > lgtm Thanks a lot!
6 years, 2 months ago (2014-09-25 21:27:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599633005/40001
6 years, 2 months ago (2014-09-25 21:28:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 4fe973cb6bc523e2b245ce59a40cd385bc74b7f5
6 years, 2 months ago (2014-09-25 22:28:28 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 22:29:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5fa39d5a7ec4f3d6034cd98dc9474f3a516f26a
Cr-Commit-Position: refs/heads/master@{#296808}

Powered by Google App Engine
This is Rietveld 408576698