Source/core/dom/PositionIterator.cpp - Issue 59963002: Unable to delete the first and the last characters of a contenteditable div with display: table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/PositionIterator.cpp

Issue 59963002: Unable to delete the first and the last characters of a contenteditable div with display: table. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Tweaking the testcase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/deleting/display-table.html ('K') | « Source/core/dom/Position.cpp ('k') | Source/core/editing/CompositeEditCommand.cpp » ('j') | Source/core/editing/htmlediting.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/PositionIterator.cpp

diff --git a/Source/core/dom/PositionIterator.cpp b/Source/core/dom/PositionIterator.cpp

index 1b5dcdd2d4bc69d13ebfb09081565dc4242d62bd..5cc76b10806b1aa7cfbe0da0200b9766bb96b019 100644

--- a/Source/core/dom/PositionIterator.cpp

+++ b/Source/core/dom/PositionIterator.cpp

@@ -157,7 +157,7 @@ bool PositionIterator::isCandidate() const

if (renderer->isText())

return !Position::nodeIsUserSelectNone(m_anchorNode) && Position(*this).inRenderedText();

- if (isRenderedTable(m_anchorNode) || editingIgnoresContent(m_anchorNode))

+ if (isTableElement(m_anchorNode) || editingIgnoresContent(m_anchorNode))

return (atStartOfNode() || atEndOfNode()) && !Position::nodeIsUserSelectNone(m_anchorNode->parentNode());

if (!isHTMLHtmlElement(m_anchorNode) && renderer->isRenderBlockFlow()) {

« LayoutTests/editing/deleting/display-table.html ('K') | « Source/core/dom/Position.cpp ('k') | Source/core/editing/CompositeEditCommand.cpp » ('j') | Source/core/editing/htmlediting.cpp » ('J')