Source/core/editing/CompositeEditCommand.cpp - Issue 59963002: Unable to delete the first and the last characters of a contenteditable div with display: table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 59963002: Unable to delete the first and the last characters of a contenteditable div with display: table. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding new method to preserve old behavior. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/execCommand/format-block-at-root-expected.txt ('K') | « Source/core/editing/Caret.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index ae7cebfceb0bea5a4f958b37bce6d3728d014522..0bf3580bb4a95d9b456a3c0698bcaba3e9c42cad 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -1117,7 +1117,7 @@ void CompositeEditCommand::moveParagraphWithClones(const VisiblePosition& startO

beforeParagraph = VisiblePosition(beforeParagraph.deepEquivalent());

afterParagraph = VisiblePosition(afterParagraph.deepEquivalent());

- if (beforeParagraph.isNotNull() && !isTableElement(beforeParagraph.deepEquivalent().deprecatedNode())

+ if (beforeParagraph.isNotNull() && !isRenderedTable(beforeParagraph.deepEquivalent().deprecatedNode())

&& ((!isEndOfParagraph(beforeParagraph) && !isStartOfParagraph(beforeParagraph)) || beforeParagraph == afterParagraph)) {

// FIXME: Trim text between beforeParagraph and afterParagraph if they aren't equal.

insertNodeAt(createBreakElement(document()), beforeParagraph.deepEquivalent());

« LayoutTests/editing/execCommand/format-block-at-root-expected.txt ('K') | « Source/core/editing/Caret.cpp ('k') | Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »