LayoutTests/editing/deleting/display-table.html - Issue 59963002: Unable to delete the first and the last characters of a contenteditable div with display: table.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/deleting/display-table.html

Issue 59963002: Unable to delete the first and the last characters of a contenteditable div with display: table. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Introducing isTableElement() Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 #tableDiv {

	6 display: table;

	7 }

	8 </style>

	9 <script src="../../resources/dump-as-markup.js"></script>

	10 </head>

	11 <body>

	12 <div id="tableDiv" contenteditable="true">Try deleting characters at the beginni ng and at the end of this line.</div>

	13 <script>

	14 Markup.description("Testcase for bug http://crbug.com/107366: Can't delete first and last characters of a root editable element with display: table");

	15

	16 Markup.waitUntilDone();

	17

	18 var testDiv = document.getElementById('tableDiv');

	19 var selection = window.getSelection();

	20

	21 selection.collapse(testDiv, 0);

	22 document.execCommand("forwardDelete");
	yosin_UTC9 2013/11/14 06:57:59 I think js-test.js is easier to write test and ver I think js-test.js is easier to write test and verify result. function testIt(caretPosition, deleteCommand, expectedString) { testDiv.innerText = 'ABCD'; selection.collapse(testDiv, selectionPosition); document.execCommand(deleteCommand); shouldBeEqualToString('testDiv.textContent', expectedString); } testIt(0, 'Delete', 'BCD'); testIt(1, 'forwardDelete', 'ABC'); finishJSTest(); Note: It is better to make each test case independent, e.g. not use modified sample in following test cases. arpitab_ 2013/11/14 07:08:19 Understand. I will post another patch with the men Show quoted text On 2013/11/14 06:57:59, Yoshi wrote: > I think js-test.js is easier to write test and verify result. > > function testIt(caretPosition, deleteCommand, expectedString) > { > testDiv.innerText = 'ABCD'; > selection.collapse(testDiv, selectionPosition); > document.execCommand(deleteCommand); > shouldBeEqualToString('testDiv.textContent', expectedString); > } > > testIt(0, 'Delete', 'BCD'); > testIt(1, 'forwardDelete', 'ABC'); > finishJSTest(); > > Note: It is better to make each test case independent, e.g. not use modified > sample in following test cases. Understand. I will post another patch with the mentioned changes.
	23 Markup.dump(testDiv, "The following markup should show the 'T' character deleted from the start word 'Try'.");

	24

	25 selection.collapse(testDiv, 1);

	26 document.execCommand("Delete");

	27 Markup.dump(testDiv, "The following markup should show the '.' character deleted from the end of the line.");

	28

	29 Markup.notifyDone();

	30 </script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/deleting/display-table-expected.txt » ('j') | Source/core/editing/CompositeEditCommand.cpp » ('J')