Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 599603002: Remove some unnecessary webkit/common/gpu and third_party/wtl deps (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary webkit/common/gpu and third_party/wtl deps mojo/aura doesn't use webkit/common/gpu any more. third_party/wtl is only used on windows and is added in a conditional if (is_win) section below. Committed: https://crrev.com/c572374f5630d7cfb592af1cae5e0adf9f80a1bb Cr-Commit-Position: refs/heads/master@{#296243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M mojo/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/aura/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_services.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sky
LGTM
6 years, 3 months ago (2014-09-23 20:14:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599603002/1
6 years, 3 months ago (2014-09-23 20:31:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0277e35ea58bfe411d0cebc6d83307c63ec6f349
6 years, 3 months ago (2014-09-23 21:10:50 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:11:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c572374f5630d7cfb592af1cae5e0adf9f80a1bb
Cr-Commit-Position: refs/heads/master@{#296243}

Powered by Google App Engine
This is Rietveld 408576698