Issue 59953005: Store prefs::kVariationsSeedDate on a variations server 304.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59953005: Store prefs::kVariationsSeedDate on a variations server 304. (Closed)

Created:
7 years, 1 month ago by Alexei Svitkine (slow)

Modified:
7 years, 1 month ago

Reviewers:
jwd

CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Store prefs::kVariationsSeedDate on a variations server 304. This prevents an issue where the variations seed not changing in a while will result in studies not actually expiring. Also, removes an unused header include. BUG=315177 TEST=New unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233406

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -1 line)			Patch
M	chrome/browser/metrics/variations/variations_service.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/metrics/variations/variations_service.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/variations/variations_service_unittest.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/59953005/1

7 years, 1 month ago (2013-11-06 15:11:04 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 1 month ago (2013-11-06 15:19:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/59953005/1

7 years, 1 month ago (2013-11-06 15:26:50 UTC) #5

Message was sent while issue was closed.

Change committed as 233406

Expand Messages | Collapse Messages