Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 599493004: Use the new java_cpp_enum rule in net. (Closed)

Created:
6 years, 3 months ago by mkosiba (inactive)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use the new java_cpp_enum rule in net. This moves most of the generated Java enums under net/ to use the java_cpp_enum rule removing the need for keeping the enums in separate list files and the need for the .template files. BUG=405532 Committed: https://crrev.com/f6ebbf6b7c4a6d0626979198cfca64cb92cb2833 Cr-Commit-Position: refs/heads/master@{#297420}

Patch Set 1 #

Patch Set 2 : add landmine #

Patch Set 3 : fix compile #

Patch Set 4 : rebase #

Patch Set 5 : fix android_aosp #

Patch Set 6 : rebase #

Patch Set 7 : one more aosp fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -165 lines) Patch
M android_webview/java_library_common.mk View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M build/get_landmines.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M net/android/BUILD.gn View 2 chunks +9 lines, -28 lines 0 comments Download
M net/android/cert_verify_result_android.h View 1 chunk +21 lines, -3 lines 0 comments Download
D net/android/cert_verify_status_android_list.h View 1 chunk +0 lines, -31 lines 0 comments Download
D net/android/java/CertVerifyStatusAndroid.template View 1 chunk +0 lines, -10 lines 0 comments Download
D net/android/java/CertificateMimeType.template View 1 chunk +0 lines, -11 lines 0 comments Download
D net/android/java/PrivateKeyType.template View 1 chunk +0 lines, -10 lines 0 comments Download
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 1 chunk +2 lines, -2 lines 0 comments Download
M net/android/java/src/org/chromium/net/X509Util.java View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M net/android/keystore.h View 1 chunk +7 lines, -3 lines 0 comments Download
D net/android/private_key_type_list.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/base/mime_util.h View 1 chunk +7 lines, -3 lines 0 comments Download
D net/base/mime_util_certificate_type_list.h View 1 chunk +0 lines, -13 lines 0 comments Download
M net/cert/cert_verify_proc_android.cc View 1 2 3 4 5 6 2 chunks +9 lines, -8 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 1 chunk +6 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mkosiba (inactive)
PTAL
6 years, 3 months ago (2014-09-24 15:05:49 UTC) #2
Ryan Hamilton
net/ LGTM
6 years, 3 months ago (2014-09-24 15:46:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599493004/60001
6 years, 2 months ago (2014-09-29 10:45:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/19608)
6 years, 2 months ago (2014-09-29 11:09:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599493004/120001
6 years, 2 months ago (2014-09-30 13:04:17 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:120001) as c254e397dd5fb79cd98fb1cd8b51cf61627bd44c
6 years, 2 months ago (2014-09-30 14:42:46 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 14:43:39 UTC) #11
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f6ebbf6b7c4a6d0626979198cfca64cb92cb2833
Cr-Commit-Position: refs/heads/master@{#297420}

Powered by Google App Engine
This is Rietveld 408576698