Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 599473002: ServiceWorker CacheID update (Closed)

Created:
6 years, 3 months ago by jkarlin
Modified:
6 years, 3 months ago
Reviewers:
michaeln, gavinp, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker CacheID update Previous design: 1. The renderer needed all references to the same ServiceWorekrCache* to have the same CacheID. 2. The renderer would only send an IPC that a CacheID was deleted when the last reference to the CacheID was deleted in javascript. After https://codereview.chromium.org/474593002/ and https://codereview.chromium.org/433793002/: 1. The renderer doesn't need all references to the same ServiceWorkerCache* to have the same CacheID. 2. The renderer will send an IPC that a CacheID is deleted after each javascript cache object is deleted. To address the change on the browser side, simply make a new CacheID for every call to GetCache and CreateCache and delete its corresponding refptr when the CacheID is dropped. BUG=392621 Committed: https://crrev.com/821ee0da2cd4a3203d30f82c15f34829d0e182c0 Cr-Commit-Position: refs/heads/master@{#296390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_listener.cc View 1 chunk +4 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jkarlin
michaeln@chromium.org: Please review changes in all horo@chromium.org: Please review changes in all Thanks!
6 years, 3 months ago (2014-09-23 14:19:14 UTC) #2
jkarlin
On 2014/09/23 14:19:14, jkarlin wrote: > mailto:michaeln@chromium.org: Please review changes in all > > mailto:horo@chromium.org: ...
6 years, 3 months ago (2014-09-23 14:19:38 UTC) #4
gavinp
lgtm
6 years, 3 months ago (2014-09-23 16:11:43 UTC) #5
horo
lgtm
6 years, 3 months ago (2014-09-24 06:25:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599473002/1
6 years, 3 months ago (2014-09-24 11:06:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8c05b7b4ba990746072abac36324d930106816fe
6 years, 3 months ago (2014-09-24 11:56:34 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 11:57:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/821ee0da2cd4a3203d30f82c15f34829d0e182c0
Cr-Commit-Position: refs/heads/master@{#296390}

Powered by Google App Engine
This is Rietveld 408576698