chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc - Issue 599463002: Use base::StringPairs where appropriate from src/chrome/browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

Issue 599463002: Use base::StringPairs where appropriate from src/chrome/browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/drive/fake_drive_service.cc ('k') | chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc » ('j') | chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

diff --git a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc b/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

index 0e020ba0139b99ee43598955eeb32381d1ca4c13..c1c9ad613f4be192ac219a925b8f229286f889da 100644

--- a/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

+++ b/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc

@@ -171,7 +171,7 @@ void GaiaWebAuthFlow::OnAuthFlowURLChange(const GURL& url) {

std::string error;

std::string expiration;

- for (std::vector<std::pair<std::string, std::string> >::iterator

+ for (base::StringPairs::iterator

it = pairs.begin();

Lei Zhang 2014/09/23 17:22:41 this now fits on the previous line

Anand Ratn (left samsung) 2014/09/24 03:50:53 Done.

it != pairs.end();

++it) {