Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 599463002: Use base::StringPairs where appropriate from src/chrome/browser (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs where appropriate from src/chrome/browser Becuase base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/027d34b737abac0f1a0f7ccb853036968cfbcdea Cr-Commit-Position: refs/heads/master@{#296362}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc View 1 10 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Ratn (left samsung)
thestig@chromium.org: Please review changes in src/chrome/browser module sky@chromium.org: Please review changes in src/chrome/browser module
6 years, 3 months ago (2014-09-23 11:47:41 UTC) #2
Lei Zhang
https://codereview.chromium.org/599463002/diff/1/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc File chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc (right): https://codereview.chromium.org/599463002/diff/1/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc#newcode175 chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc:175: it = pairs.begin(); this now fits on the previous ...
6 years, 3 months ago (2014-09-23 17:22:41 UTC) #3
Anand Ratn (left samsung)
PTAL in new patchset. https://codereview.chromium.org/599463002/diff/1/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc File chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc (right): https://codereview.chromium.org/599463002/diff/1/chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc#newcode175 chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc:175: it = pairs.begin(); On 2014/09/23 ...
6 years, 3 months ago (2014-09-24 03:50:54 UTC) #5
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-24 05:06:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599463002/20001
6 years, 3 months ago (2014-09-24 05:06:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 134e477a65bdf9d7e59aad1b8acbe4387d871b8e
6 years, 3 months ago (2014-09-24 07:40:18 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 07:40:50 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/027d34b737abac0f1a0f7ccb853036968cfbcdea
Cr-Commit-Position: refs/heads/master@{#296362}

Powered by Google App Engine
This is Rietveld 408576698