[TurboFan]: Add JSON output for the visualizer

[TurboFan]: Add JSON output for the visualizer

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24220

[danno, 2014-09-24 15:10:40]

danno@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[danno, 2014-09-24 15:10:52]

PTAL

[Michael Starzinger, 2014-09-25 08:40:06]

LGTM.

https://codereview.chromium.org/599453002/diff/20001/src/compiler/graph-visua...
File src/compiler/graph-visualizer.cc (right):

https://codereview.chromium.org/599453002/diff/20001/src/compiler/graph-visua...
src/compiler/graph-visualizer.cc:131: bool visible =
(NodeProperties::IsControl(from) || opcode == IrOpcode::kPhi ||
suggestion: In the long run we could try to encode the logic of when to show
which edge in the visualization tool and the JSON output would just contain the
raw data to make that decision. Of course I am fine with leaving this here for
now until we have an idea of what raw data we will need. WDYT?

[danno, 2014-09-25 10:05:04]

Please take another look. Made the output more general so that the decision
about initial visibility can be in the tool.

[Michael Starzinger, 2014-09-25 11:02:51]

Still LGTM, just one issue in the pipeline.

https://codereview.chromium.org/599453002/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/599453002/diff/40001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:110: of << AsJSON(*graph);
This seems to disable dumping of ".dot" files, I think for now we should still
keep dumping them.

[danno, 2014-09-25 11:14:02]

Committed patchset #5 (id:80001) manually as 24220 (tree was closed).