Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 599443003: Activate and inactivate keyboard mic on ChromeOS. (Closed)

Created:
6 years, 2 months ago by Henrik Grunell
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@check_kmic_set_effect
Project:
chromium
Visibility:
Public.

Description

Activate and inactivate keyboard mic on ChromeOS. Based on keyboard layout for opened and closed streams, keep count of those containing keyboard mic. Activate mic for first such stream, inactivate when last one is closed. BUG=345296 Committed: https://crrev.com/3a95511054543ffb7f1b83fd8f38499ac86dad59 Cr-Commit-Position: refs/heads/master@{#296217}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -2 lines) Patch
M content/browser/renderer_host/media/audio_input_device_manager.h View 2 chunks +21 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 4 chunks +53 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 2 chunks +14 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 9 chunks +54 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Henrik Grunell
6 years, 2 months ago (2014-09-23 12:19:30 UTC) #2
Henrik Grunell
6 years, 2 months ago (2014-09-23 13:43:23 UTC) #4
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/599443003/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc File content/browser/renderer_host/media/audio_input_renderer_host.cc (right): https://codereview.chromium.org/599443003/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc#newcode292 content/browser/renderer_host/media/audio_input_renderer_host.cc:292: DoCreateStream(stream_id, render_view_id, session_id, config); fix indent https://codereview.chromium.org/599443003/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc#newcode551 content/browser/renderer_host/media/audio_input_renderer_host.cc:551: ...
6 years, 2 months ago (2014-09-23 13:47:37 UTC) #5
Henrik Grunell
https://codereview.chromium.org/599443003/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc File content/browser/renderer_host/media/audio_input_renderer_host.cc (right): https://codereview.chromium.org/599443003/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc#newcode292 content/browser/renderer_host/media/audio_input_renderer_host.cc:292: DoCreateStream(stream_id, render_view_id, session_id, config); On 2014/09/23 13:47:36, tommi wrote: ...
6 years, 2 months ago (2014-09-23 15:00:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599443003/20001
6 years, 2 months ago (2014-09-23 15:00:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as ca67ef9119db59c332c8fe13710bb8ef52402cc1
6 years, 2 months ago (2014-09-23 20:35:57 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 20:36:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a95511054543ffb7f1b83fd8f38499ac86dad59
Cr-Commit-Position: refs/heads/master@{#296217}

Powered by Google App Engine
This is Rietveld 408576698