Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 599403002: Make encoding-labels test easier to debug (Closed)

Created:
6 years, 2 months ago by jungshik at Google
Modified:
6 years, 2 months ago
Reviewers:
jsbell
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Make encoding-labels test easier to debug It's hard to find out which label failed for a given encoding. Revise encoding-labels.html to print out {encoding name, label) pair instead of just 'encoding name' for each test run. BUG=412053 TEST=fast/encoding/encoding-labels.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182685

Patch Set 1 #

Patch Set 2 : indentation corrected #

Patch Set 3 : print name before label #

Patch Set 4 : line break change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/fast/encoding/api/encoding-labels.html View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jungshik at Google
Hi Joshua, can you take a look? While working on the bug in BUG field, ...
6 years, 2 months ago (2014-09-25 09:00:03 UTC) #2
jsbell
lgtm
6 years, 2 months ago (2014-09-25 14:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599403002/60001
6 years, 2 months ago (2014-09-25 14:15:43 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 15:55:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 182685

Powered by Google App Engine
This is Rietveld 408576698