Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 599383002: [turbofan] add some simplifications in the machine operator reducer (Closed)

Created:
6 years, 2 months ago by vincent.belliard
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] add some simplifications in the machine operator reducer Simplify the '+', '-' and '%' operators with some basic constants (0, 1 or NaN). R=titzer@google.com, bmeurer@chromium.org BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M src/compiler/machine-operator-reducer.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 4 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vincent.belliard
6 years, 2 months ago (2014-09-25 08:23:50 UTC) #1
titzer
https://codereview.chromium.org/599383002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/599383002/diff/1/src/compiler/machine-operator-reducer.cc#newcode352 src/compiler/machine-operator-reducer.cc:352: return Replace(m.left().node()); // x - 0 => x Is ...
6 years, 2 months ago (2014-09-25 09:08:41 UTC) #3
vincent.belliard
https://codereview.chromium.org/599383002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/599383002/diff/1/src/compiler/machine-operator-reducer.cc#newcode352 src/compiler/machine-operator-reducer.cc:352: return Replace(m.left().node()); // x - 0 => x > ...
6 years, 2 months ago (2014-09-25 09:51:19 UTC) #4
titzer
lgtm
6 years, 2 months ago (2014-09-25 09:53:19 UTC) #5
vincent.belliard
6 years, 2 months ago (2014-09-29 08:34:29 UTC) #6
r 24270

Powered by Google App Engine
This is Rietveld 408576698