ChannelMojo: Handle when ChannelMojo outlives ChannelMojoHost

ipc/mojo/ipc_channel_mojo_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/mojo/ipc_channel_mojo_host.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "ipc/mojo/ipc_channel_mojo.h"
 
 namespace IPC {
 
+namespace {
+
+void DeleteChannelMojoHost(IPC::ChannelMojoHost* ptr) {

[viettrungluu, 2014/09/25 19:38:34]

Can't you use DeletePointer (from bind_helpers.h) instead?

[Hajime Morrita, 2014/09/25 22:00:03]

Done.

+  delete ptr;
+}
+
+}  // namespace
+
 ChannelMojoHost::ChannelMojoHost(scoped_refptr<base::TaskRunner> task_runner)
-    : weak_factory_(this), task_runner_(task_runner), channel_(NULL) {
+    : weak_factory_(this), task_runner_(task_runner) {
 }
 
 ChannelMojoHost::~ChannelMojoHost() {
 }

[viettrungluu, 2014/09/25 19:38:34]

DCHECK_EQ(base::MessageLoop::current()->message_loop_proxy(), task_runner_)?

[Hajime Morrita, 2014/09/25 22:00:03]

Done.

 
 void ChannelMojoHost::OnClientLaunched(base::ProcessHandle process) {
   if (task_runner_ == base::MessageLoop::current()->message_loop_proxy()) {
-    InvokeOnClientLaunched(process);
+    if (channel_)
+      channel_->OnClientLaunched(process);
   } else {
-    task_runner_->PostTask(FROM_HERE,
-                           base::Bind(&ChannelMojoHost::InvokeOnClientLaunched,
-                                      weak_factory_.GetWeakPtr(),
-                                      process));
+    // Don't check |channel_| here as it is safe only on IO thread.
+    task_runner_->PostTask(
+        FROM_HERE,
+        base::Bind(&ChannelMojo::OnClientLaunched, channel_, process));
   }
 }
 
-void ChannelMojoHost::InvokeOnClientLaunched(base::ProcessHandle process) {
-  if (!channel_)
-    return;
-  channel_->OnClientLaunched(process);
+void ChannelMojoHost::DeleteThisSoon() {
+  task_runner_->PostTask(FROM_HERE, base::Bind(&DeleteChannelMojoHost, this));
 }
 
-void ChannelMojoHost::OnChannelCreated(ChannelMojo* channel) {
-  DCHECK(channel_ == NULL);
+base::WeakPtr<ChannelMojoHost> ChannelMojoHost::ToWeakPtr() {
+  return weak_factory_.GetWeakPtr();
+}
+
+void ChannelMojoHost::OnChannelCreated(base::WeakPtr<ChannelMojo> channel) {
+  DCHECK(!channel_);
   channel_ = channel;
 }
 
-void ChannelMojoHost::OnChannelDestroyed() {
-  DCHECK(channel_ != NULL);
-  channel_ = NULL;
+void ChannelMojoHostDeleter::operator()(ChannelMojoHost* ptr) const {
+  ptr->DeleteThisSoon();
 }
 
 }  // namespace IPC